heyday-marketing-gmbh/hartmann-foto_documentation
11
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

cleanup and unit tests

Browse Source
This commit is contained in:
verboomp
2026-02-03 12:02:45 +01:00
parent 6cb7c768e0
commit 508b1b4380
3 changed files with 17 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
hartmann-foto-documentation-app/src/main/java/marketing/heyday/hartmann/fotodocumentation/core/utils/EvaluationUtil.java
View File

@@ -12,9 +12,9 @@ package marketing.heyday.hartmann.fotodocumentation.core.utils;
public class EvaluationUtil { public class EvaluationUtil {
private static final int MIN_VALUE = 1; private static final int MIN_VALUE = 1;
private static final int MAX_VALUE = 1; private static final int MAX_VALUE = 3;
public boolean isValid(Integer value) { public boolean isInValid(Integer value) {
return (value == null || value < MIN_VALUE || value > MAX_VALUE); return (value == null || value < MIN_VALUE || value > MAX_VALUE);
} }
} }

2
hartmann-foto-documentation-app/src/main/java/marketing/heyday/hartmann/fotodocumentation/rest/PictureResource.java
View File

@@ -58,7 +58,7 @@ public class PictureResource {
@Operation(summary = "Update evaluation for picture data to database") @Operation(summary = "Update evaluation for picture data to database")
@ApiResponse(responseCode = "200", description = "Task successfully updated") @ApiResponse(responseCode = "200", description = "Task successfully updated")
public Response doUpdateEvaluation(@PathParam("id") Long id, @QueryParam("evaluation") Integer value) { public Response doUpdateEvaluation(@PathParam("id") Long id, @QueryParam("evaluation") Integer value) {
if (!evaluationUtil.isValid(value)) { if (evaluationUtil.isInValid(value)) {
return Response.status(Status.BAD_REQUEST).build(); return Response.status(Status.BAD_REQUEST).build();
} }
StorageState state = pictureService.updateEvaluationStatus(id, value); StorageState state = pictureService.updateEvaluationStatus(id, value);

28
hartmann-foto-documentation-app/src/test/java/marketing/heyday/hartmann/fotodocumentation/core/utils/EvaluationUtilTest.java
View File

@@ -24,37 +24,37 @@ class EvaluationUtilTest {
} }
@Test @Test
void isValid_null_returnsTrue() { void isInValid_null_returnsTrue() {
assertTrue(evaluationUtil.isValid(null)); assertTrue(evaluationUtil.isInValid(null));
} }
@Test @Test
void isValid_zero_returnsTrue() { void isInValid_zero_returnsTrue() {
assertTrue(evaluationUtil.isValid(0)); assertTrue(evaluationUtil.isInValid(0));
} }
@Test @Test
void isValid_negativeValue_returnsTrue() { void isInValid_negativeValue_returnsTrue() {
assertTrue(evaluationUtil.isValid(-1)); assertTrue(evaluationUtil.isInValid(-1));
} }
@Test @Test
void isValid_one_returnsFalse() { void isInValid_one_returnsFalse() {
assertFalse(evaluationUtil.isValid(1)); assertFalse(evaluationUtil.isInValid(1));
} }
@Test @Test
void isValid_two_returnsTrue() { void isInValid_two_returnsFlse() {
assertTrue(evaluationUtil.isValid(2)); assertFalse(evaluationUtil.isInValid(2));
} }
@Test @Test
void isValid_three_returnsTrue() { void isInValid_three_returnsFalse() {
assertTrue(evaluationUtil.isValid(3)); assertFalse(evaluationUtil.isInValid(3));
} }
@Test @Test
void isValid_largeValue_returnsTrue() { void isInValid_largeValue_returnsTrue() {
assertTrue(evaluationUtil.isValid(100)); assertTrue(evaluationUtil.isInValid(100));
} }
} }