From 508b1b4380b756d4dd56b305048540c64ab62c57 Mon Sep 17 00:00:00 2001 From: verboomp Date: Tue, 3 Feb 2026 12:02:45 +0100 Subject: [PATCH] cleanup and unit tests --- .../core/utils/EvaluationUtil.java | 4 +-- .../rest/PictureResource.java | 2 +- .../core/utils/EvaluationUtilTest.java | 28 +++++++++---------- 3 files changed, 17 insertions(+), 17 deletions(-) diff --git a/hartmann-foto-documentation-app/src/main/java/marketing/heyday/hartmann/fotodocumentation/core/utils/EvaluationUtil.java b/hartmann-foto-documentation-app/src/main/java/marketing/heyday/hartmann/fotodocumentation/core/utils/EvaluationUtil.java index 95536f1..0a45218 100644 --- a/hartmann-foto-documentation-app/src/main/java/marketing/heyday/hartmann/fotodocumentation/core/utils/EvaluationUtil.java +++ b/hartmann-foto-documentation-app/src/main/java/marketing/heyday/hartmann/fotodocumentation/core/utils/EvaluationUtil.java @@ -12,9 +12,9 @@ package marketing.heyday.hartmann.fotodocumentation.core.utils; public class EvaluationUtil { private static final int MIN_VALUE = 1; - private static final int MAX_VALUE = 1; + private static final int MAX_VALUE = 3; - public boolean isValid(Integer value) { + public boolean isInValid(Integer value) { return (value == null || value < MIN_VALUE || value > MAX_VALUE); } } diff --git a/hartmann-foto-documentation-app/src/main/java/marketing/heyday/hartmann/fotodocumentation/rest/PictureResource.java b/hartmann-foto-documentation-app/src/main/java/marketing/heyday/hartmann/fotodocumentation/rest/PictureResource.java index bda5cf6..cff6d69 100644 --- a/hartmann-foto-documentation-app/src/main/java/marketing/heyday/hartmann/fotodocumentation/rest/PictureResource.java +++ b/hartmann-foto-documentation-app/src/main/java/marketing/heyday/hartmann/fotodocumentation/rest/PictureResource.java @@ -58,7 +58,7 @@ public class PictureResource { @Operation(summary = "Update evaluation for picture data to database") @ApiResponse(responseCode = "200", description = "Task successfully updated") public Response doUpdateEvaluation(@PathParam("id") Long id, @QueryParam("evaluation") Integer value) { - if (!evaluationUtil.isValid(value)) { + if (evaluationUtil.isInValid(value)) { return Response.status(Status.BAD_REQUEST).build(); } StorageState state = pictureService.updateEvaluationStatus(id, value); diff --git a/hartmann-foto-documentation-app/src/test/java/marketing/heyday/hartmann/fotodocumentation/core/utils/EvaluationUtilTest.java b/hartmann-foto-documentation-app/src/test/java/marketing/heyday/hartmann/fotodocumentation/core/utils/EvaluationUtilTest.java index 1d78798..e728af8 100644 --- a/hartmann-foto-documentation-app/src/test/java/marketing/heyday/hartmann/fotodocumentation/core/utils/EvaluationUtilTest.java +++ b/hartmann-foto-documentation-app/src/test/java/marketing/heyday/hartmann/fotodocumentation/core/utils/EvaluationUtilTest.java @@ -24,37 +24,37 @@ class EvaluationUtilTest { } @Test - void isValid_null_returnsTrue() { - assertTrue(evaluationUtil.isValid(null)); + void isInValid_null_returnsTrue() { + assertTrue(evaluationUtil.isInValid(null)); } @Test - void isValid_zero_returnsTrue() { - assertTrue(evaluationUtil.isValid(0)); + void isInValid_zero_returnsTrue() { + assertTrue(evaluationUtil.isInValid(0)); } @Test - void isValid_negativeValue_returnsTrue() { - assertTrue(evaluationUtil.isValid(-1)); + void isInValid_negativeValue_returnsTrue() { + assertTrue(evaluationUtil.isInValid(-1)); } @Test - void isValid_one_returnsFalse() { - assertFalse(evaluationUtil.isValid(1)); + void isInValid_one_returnsFalse() { + assertFalse(evaluationUtil.isInValid(1)); } @Test - void isValid_two_returnsTrue() { - assertTrue(evaluationUtil.isValid(2)); + void isInValid_two_returnsFlse() { + assertFalse(evaluationUtil.isInValid(2)); } @Test - void isValid_three_returnsTrue() { - assertTrue(evaluationUtil.isValid(3)); + void isInValid_three_returnsFalse() { + assertFalse(evaluationUtil.isInValid(3)); } @Test - void isValid_largeValue_returnsTrue() { - assertTrue(evaluationUtil.isValid(100)); + void isInValid_largeValue_returnsTrue() { + assertTrue(evaluationUtil.isInValid(100)); } }